Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message when lefthook not installed #679

Open
cheruvian opened this issue Jan 17, 2024 · 2 comments
Open

Misleading error message when lefthook not installed #679

cheruvian opened this issue Jan 17, 2024 · 2 comments
Labels
bug Something isn't working stale

Comments

@cheruvian
Copy link

What happened?

When lefthook is not installed (on OSX), it throws a failed to install dependencies error which is misleading.

We should

  1. Update the README to note that lefthook is a prerequisite
  2. Improve the error message if lefthook is not installed

Current experience:

% npx create-remix@latest --template meza/trance-stack trance-stack
Need to install the following packages:
[email protected]
Ok to proceed? (y) 

 remix   v2.5.0 💿 Let's build a better website...
      ◼  Directory: Using trance-stack as project directory

      ◼  Template: Using meza/trance-stack...
      ✔  Template copied

   git   Initialize a new git repository?
         No

  deps   Install dependencies with npm?
         Yes

 ██████  Dependencies installing with npm...

      ▲  Oh no! Failed to install dependencies.

What did you expect to happen?

I expected it to say

lefthook is not installed

What version of Remix are you using?

2.5.0

@cheruvian cheruvian added the bug Something isn't working label Jan 17, 2024
@eskot
Copy link

eskot commented Mar 13, 2024

I just ran into the same issue and was able to resolve by making sure the git project was initialized. After running git init manually, I was able to successfully run npm install with no failures from lefthook. Now I need to know why the repo was not initialized when I selected yes during the setup - which is another topic :-)

Copy link

stale bot commented Jun 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants