Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the nav_links in the mobile menu #90

Open
JulienPradet opened this issue Feb 19, 2019 · 1 comment
Open

Display the nav_links in the mobile menu #90

JulienPradet opened this issue Feb 19, 2019 · 1 comment

Comments

@JulienPradet
Copy link

JulienPradet commented Feb 19, 2019

Hi! 👋

First of all, thank you for open sourcing this docs theme. We've used it in Front-Commerce's documentation and it is really great!

However, I've noticed that there's an issue when displaying the nav_links on mobile. They should appear above the sidebar but are hidden behind the header. It is displayed correctly though when you start in desktop mode and resize to mobile.

This can be seen in Apollo Docs : https://www.apollographql.com/docs/

We've made a fix on our side, but I'm not sure that the PR would be OK for you since our fix uses flexbox and I've noticed that it does not seem to appear in your codebase. If it's OK for you though, I could make a PR later on.

Our fix: front-commerce/developers.front-commerce.com@c122803
A working preview: https://deploy-preview-18--elastic-austin-cf9d40.netlify.com/docs/

@JulienPradet
Copy link
Author

Oops, nevermind for my fix. It has compatibility issues. I'll try to come up with a different one, but the bug is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant