-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Inserts into Db when Uplaoding Papers #84
Comments
@rajivharlalka or @harshkhandeparkar please update the state of this issue to be reflected on the kanban. |
@rajivharlalka db god :nam: |
Not a priority issue, but a good first one. Would like some fresher to take
it up.
|
Putting this on hold since the change would make error handling a lot more complicated. Since we send a per-paper error message, it would be harder to handle db rollbacks if only one of the files fails to write. Also, since all would be inserted into the db at once, an error would fail to upload all papers. The performance benefit for our use case is most probably not worth the extra code complication. Ref: https://metakgp.slack.com/archives/C05KTAL5ARM/p1729064846865189 |
Is your feature request related to a problem? Please describe.
Currently when multiple papers are uploaded, metadata for each paper is inserted in individual insert statement. These inserts can be batched into a single one for performance bonus.
The text was updated successfully, but these errors were encountered: