Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HTTP API DoS / No back-off on API failures #361

Open
broglep opened this issue Jan 5, 2025 · 1 comment
Open

[Bug]: HTTP API DoS / No back-off on API failures #361

broglep opened this issue Jan 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@broglep
Copy link

broglep commented Jan 5, 2025

Hardware

Not Applicable

Connection Type

HTTP

Local or Hosted

http://meshtastic.local

Firmware Version

Description

The web interface constantly performs new HTTP API calls even if they have failed. There seems to be no time in between requests and this essential performs an denial of service to the API and at the same time drives up CPU usage of the browser.

Web web interface should add some delay after failed request, ideally an exponential backoff and maybe even treat 4xx and 5xx differently. For 4xx response codes it is unlikely that retrying will help anything, so web interface should probably abort. For 5xx response codes the API call can be retried after some backoff

Relevant console output

No response

@broglep broglep added the bug Something isn't working label Jan 5, 2025
@danditomaso
Copy link
Contributor

Thanks for the report! Can you please open this issue in the JS library repo : https://github.com/meshtastic/js ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants