Fix returned
attribute logic
#18
Labels
status: pending 🕥
In a waiting state
type: architecture 🏛️
Changes to code architecture
type: maintenance 🔧
Fixes to and refactoring codebase
Currently the
Loan
class contains a boolean attribute calledreturned
, however, it's occurred to me that a loan isn't returned, a loaned item is.To fix this we can either:
returned
attribute toactive
to indicate whether or not the loan is currently active, orreturned
attribute from theLoan
class altogether and add it to theItem
class.I'm more partial to the first option because if we go with the second option, we'll have to refactor other code as well.
The text was updated successfully, but these errors were encountered: