Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Variant Button glitched #2822

Closed
AltayAkkus opened this issue Dec 18, 2022 · 6 comments
Closed

Edit Variant Button glitched #2822

AltayAkkus opened this issue Dec 18, 2022 · 6 comments

Comments

@AltayAkkus
Copy link

Bug report

When trying to edit a variant, the radix button is put under the next variant, so the UI becomes very ugly.

Describe the bug

The z-index set to the radix button does not work properly, because the parent element is neither position: relative nor does it have a own z-index set, so the z-index of the parent div is automatically higher than the highest child z-index, so our radix button is not shown over the elements.

System information

Medusa version (including plugins): demo.medusajs.com, so latest.
Node.js version: demo.medusajs.com
Database: demo.medusajs.com
Operating system: Windows 10
Browser (if relevant): Firefox (latest) and Chrome (latest)

Steps to reproduce the behavior

  1. Go to demo.medusajs.com
  2. Click on Variants -> Edit Variants
  3. Click a random three-point menu
  4. See error
    grafik

Expected behavior

grafik

@olivermrbl
Copy link
Contributor

Thanks for filing an issue. I cannot reproduce it on my Mac, so it must be tied to your OS. Can I get you to open the issue in our admin repository and we'll have a look at it asap?

@jhoffmann99
Copy link
Contributor

I'm interested in fixing the bug. Can you assign it to me ?

@olivermrbl
Copy link
Contributor

That's great @jhoffmann99! Feel to give it a go :)

@jhoffmann99
Copy link
Contributor

I was able to reproduce the issue on my windows 10 machine. However I couldn't find a solution yet.

@AltayAkkus
Copy link
Author

I can fix the bug when someone points me to the correct file, I could not find it :D

@jhoffmann99 jhoffmann99 removed their assignment Dec 19, 2022
@AltayAkkus
Copy link
Author

Reported and fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants