Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/api/deploy-info.version is not semver valid for final releases #8790

Closed
dianabarsan opened this issue Jan 8, 2024 · 2 comments
Closed

/api/deploy-info.version is not semver valid for final releases #8790

dianabarsan opened this issue Jan 8, 2024 · 2 comments
Assignees
@dianabarsan
Labels
Affects: 4.0.1 Affects: 4.1.2 Affects: 4.2.4 Affects: 4.3.2 Affects: 4.4.2 Affects: 4.5.1 Affects: 4.5.2 Type: Bug Fix something that isn't working as intended
Milestone
4.6.0

Comments

@dianabarsan
Copy link
Member

Describe the bug
Instead of returning the semver valid version of the app, api/build-info returns the build version.

To Reproduce

Steps to reproduce the behavior:

  1. Deploy 4.5.1
  2. Get api/deploy-info
  3. Notice that version field looks like 4.5.0.7180278601

Expected behavior
Version should be semver valid.

Environment

  • App: api
  • Version: 4.0.0
@dianabarsan dianabarsan self-assigned this Jan 8, 2024
@dianabarsan dianabarsan added this to the 4.6.0 milestone Jan 8, 2024
@dianabarsan dianabarsan mentioned this issue Jan 10, 2024
Merged
5 tasks
@1yuv
Copy link
Member

1yuv commented Jan 10, 2024

Thanks for this issue @dianabarsan . Because of this invalid version, cht-conf was also failing to upload documents to instnace and the fix is available on this PR

dianabarsan added a commit that referenced this issue Jan 11, 2024
@dianabarsan
fix(#8790): fix api/deploy-info version for tags
e16f5df 
Forces the response of api/deploy-info.version to be semver valid.

#8790
@dianabarsan
Copy link
Member Author

Merged to master.

@dianabarsan dianabarsan mentioned this issue Mar 23, 2024
Merged
5 tasks
@dianabarsan dianabarsan mentioned this issue Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianabarsan dianabarsan

Labels
Affects: 4.0.1 Affects: 4.1.2 Affects: 4.2.4 Affects: 4.3.2 Affects: 4.4.2 Affects: 4.5.1 Affects: 4.5.2 Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
3 participants
@1yuv @dianabarsan @latin-panda