Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely unlikely soft lock #73

Open
mcgrew opened this issue Aug 27, 2018 · 2 comments
Open

Extremely unlikely soft lock #73

mcgrew opened this issue Aug 27, 2018 · 2 comments
Assignees
Labels

Comments

@mcgrew
Copy link
Owner

mcgrew commented Aug 27, 2018

If you defeat the dragonlord before learning return AND you have no keys AND you have no wings AND Tantegel and Charlock are on opposite continents AND the entrance to swamp cave on Charlock's side is in the back of Garinham AND there is no cave on Charlock's continent with a non-keylocked magic key or wings, then you can't get back to Tantegel after defeating the Dragonlord.

@mcgrew mcgrew added this to the 2.1 milestone Aug 27, 2018
@mcgrew mcgrew self-assigned this Aug 27, 2018
@mcgrew mcgrew added the bug label Aug 27, 2018
@mcgrew mcgrew modified the milestones: 2.1, 2.2 Jun 20, 2019
@CaitSith2
Copy link
Contributor

I have an idea how to resolve this softlock. check for the conditions in the randomizer, and if so, ensure either a key, or a wing is in the single out of way chest in charlock castle, or any other cave on the same contenent charlock castle. In fact, the single chest that can be accessed in charlock without a key is one possible location that is always accessable no matter what.

@mcgrew mcgrew modified the milestones: 2.2, 2.3 Jul 12, 2020
@mcgrew mcgrew removed this from the 2.3 milestone Sep 17, 2021
@juef17
Copy link

juef17 commented Feb 17, 2024

While it might be the most elegant solution to completely avoid such situations, perhaps an easy fix would simply to fill the hero's key count upon defeating the Dragonlord?

vpatch(rom, 0xe9e8, 2, 0x50, 0xc9); // Hook in place of a JSR WaitForNMI in the post-DL fight
vpatch(rom, 0xc950, 8,
       0xa9, 0x06, // lda 6
       0x85, 0xbf, // sta to keys
       0x20, 0x74, 0xff, // original jsr
       0x60); // rts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants