Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If this->NetBegin() fails, shutdown the LMIC. #95

Open
terrillmoore opened this issue Apr 13, 2019 · 0 comments
Open

If this->NetBegin() fails, shutdown the LMIC. #95

terrillmoore opened this issue Apr 13, 2019 · 0 comments
Assignees
@terrillmoore
Labels
bug enhancement

Comments

@terrillmoore
Copy link
Member

If provisioning style is kNone, this->NetBegin() will fail. But this leaves the LMIC enabled, so if the user tries to send, the LMIC will start trying to join (with invalid credentials). This is at least confusing and at worst mystifying.

We should call LMIC_shutdown() if NetBegin() fails. This should cause TXs to bounce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore