feat(Android): show live data indicator on predictions #612
+106
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
reviewed
Dec 31, 2024
| @@ -60,57 +60,65 @@ fun formatTime(time: Instant): String = | |||
| format.format(time.toLocalDateTime(TimeZone.currentSystemDefault()).toJavaLocalDateTime()) | |||
|
|
|||
| @Composable | |||
| fun UpcomingTripView(state: UpcomingTripViewState) { | |||
| fun UpcomingTripView(state: UpcomingTripViewState, hideRealtimeIndicators: Boolean = false) { | |||
There was a problem hiding this comment.
suggestion: maybe worth a test that the indicator image is included when expected
KaylaBrady
reviewed
Dec 31, 2024
| if (!hideIndicator) { | ||
| Image( | ||
| painterResource(R.drawable.live_data), | ||
| contentDescription = null, |
There was a problem hiding this comment.
question(non-blocking): should there be a content description here, like "live"? This seems like an important symbol to convey to Talk Back users, though acknowledge that this is matching the existing iOS behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Nearby | Realtime indicator
I tried making this a custom modifier like it is on iOS, but Android modifiers can't (as far as I was able to tell) just wrap the entire component with another Composable.
iOS
android
Testing
Manually verified (since testing the presence of semantically-invisible UI elements in Android is a bit difficult) that the icons show correctly and look the same way they do on iOS.