feat(Android): allow small sheet size #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Nearby | Sheet / navigation
There is a third-party library that we could consider instead, but it's got outstanding issues that haven't been so much as acknowledged for months, and it doesn't provide an equivalent to the full Scaffold component, so we'd need to copy in some of the Layout stuff anyway. (I also didn't check for this until after I had already done most of this work.)
iOS
android
Testing
Manually verified that the new sheet has all three sizes and that the Mapbox attribution footer is in the right place at the sizes where the map is visible.