From 1ad36578001460af2f35b71e68c39d005916b819 Mon Sep 17 00:00:00 2001
From: Cristen Jones <cjones3@mbta.com>
Date: Fri, 31 May 2024 14:55:44 -0400
Subject: [PATCH] test(TimetableController): update values, add note

---
 .../schedule/timetable_controller_test.exs          | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/test/dotcom_web/controllers/schedule/timetable_controller_test.exs b/test/dotcom_web/controllers/schedule/timetable_controller_test.exs
index 440263c999..43cd7d0187 100644
--- a/test/dotcom_web/controllers/schedule/timetable_controller_test.exs
+++ b/test/dotcom_web/controllers/schedule/timetable_controller_test.exs
@@ -180,18 +180,23 @@ defmodule DotcomWeb.ScheduleController.TimetableControllerTest do
     end
 
     test "trip_stops: overrides position of certain shuttle stops", %{conn: conn} do
+      # uses special values that are from the TimetableController
+      # @shuttle_overrides
+      special_stop_id = "place-NHRML-0127"
+      special_stop_name = "Ballardvale"
+
       Stops.Repo.Mock
       |> expect(:by_trip, fn "trip-1" ->
         @stops ++
           [
-            %Stop{id: "4", name: "Reading"},
+            %Stop{id: "4", name: special_stop_name},
             %Stop{id: "5"},
             %Stop{id: "6"}
           ]
       end)
       |> expect(:by_trip, fn "trip-2" ->
         [
-          %Stop{id: "NHRML-0127-B"}
+          %Stop{id: special_stop_id}
         ]
       end)
 
@@ -201,12 +206,12 @@ defmodule DotcomWeb.ScheduleController.TimetableControllerTest do
             %Schedule{stop: %Stop{id: "4"}, trip: %Trip{}},
             %Schedule{stop: %Stop{id: "5"}, trip: %Trip{}},
             %Schedule{stop: %Stop{id: "6"}, trip: %Trip{}},
-            %Schedule{stop: %Stop{id: "NHRML-0127-B"}, trip: %Trip{}}
+            %Schedule{stop: %Stop{id: special_stop_id}, trip: %Trip{}}
           ]
 
       %{trip_stops: trip_stops} = build_timetable(conn, schedules)
 
-      assert Enum.map(trip_stops, & &1.id) == ["1", "2", "3", "4", "NHRML-0127-B", "5", "6"]
+      assert ["1", "2", "3", "4", ^special_stop_id, "5", "6"] = Enum.map(trip_stops, & &1.id)
     end
   end