-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXCLUDED_APPLICATIONS settings #292
Comments
Yes, I agree that the way we currently find discover locale paths is too aggressive: we essentially try to find all possible locations for PO files using
We only exclude applications from the first list, but if for some reason your app also matches 2 or 3, we can't easily detect that. Also, you might want to try using
|
Thanks for reply. I read about Nonetheless, I don't see why |
Yes, as I mentioned above we look for catalogs by app (in which case the exclusion works) and by various other means (not necessarily by app) in which cases EXCLUDED_APPS doesn't have any effect. The relevant bit of code is here: https://github.com/mbi/django-rosetta/blob/develop/rosetta/poutil.py#L33 if you'd like to take a closer look. Pull requests are as always welcome. 🙏 |
Thanks, and is this supposed to be expected behaviour? Looking deeper into the code, I basically only want "project" po_filter: django-rosetta/rosetta/views.py Line 68 in c76d829
I don't want people to see or translate third party or django apps at this point. We really translate only our frontend and don't need this. This would only confuse translators + it unnecessarily gives out sensitive information about project paths on the server. What would you say to making this settings configurable? Lastly, I was trying to run tests and play with it very slightly and some tests were failing, I haven't found any instructions on how to set it up, is there a doc? It may be some external component missing that I don't have installed, I really haven't looked much into that. |
I am trying to use this settings, but whatever I try, I see no effect. I see there are unit tests and they are working so everything seems fine.
I even literally tried:
But whatever I do, I see in the list all the translation files of all the apps. Anything obvious I am doing wrong?
The text was updated successfully, but these errors were encountered: