Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bulk annotation/association endpoints for updates/deletes #51

Open
kevinsbarnard opened this issue Nov 16, 2023 · 8 comments
Open
Assignees
Labels
core Changes to the application core enhancement New feature or request

Comments

@kevinsbarnard
Copy link
Collaborator

VARS GridView currently does one request per update/delete of bounding box annotation data. This should be swapped out for the bulk update/delete endpoints for efficiency.

@kevinsbarnard kevinsbarnard added enhancement New feature or request core Changes to the application core labels Nov 16, 2023
@kevinsbarnard kevinsbarnard self-assigned this Nov 16, 2023
@hohonuuli
Copy link
Member

There's a an existing one at POST anno/v1/associations/bulk that accepts a body with an array of Association data (as json)

@kevinsbarnard
Copy link
Collaborator Author

Thanks @hohonuuli! You're right, I misspoke today in the meeting and just looked over the annosaurus code. Not sure why I didn't implement these before. I will use PUT anno/v1/annotations/bulk for annotation updates and PUT anno/v1/associations/bulk for association (bounding box data) updates.

@hohonuuli
Copy link
Member

One more detail ... anno/v1/annotations/bulk will only change information in the imaged_moments and observations tables. Any changes to image_references or associations is ignored. (That's intentional BTW)

@kevinsbarnard
Copy link
Collaborator Author

Good to know -- Gridview should only be changing the observation concept via anno/v1/annotations/bulk.

@kevinsbarnard
Copy link
Collaborator Author

@hohonuuli
Copy link
Member

Found the issue. I've patched it in code and will release a fix tomorrow.

@hohonuuli
Copy link
Member

Got delayed a bit dealing with an upgrade to Scalatra 3/Jetty 11. They're resolved now and integration testing looks good. I've pushed a new release as annosaurus 0.16.0. New release has been deployed internally.

@lonnylundsten
Copy link

@kevinsbarnard Looks like this may be OK to close as completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to the application core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants