Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand DigitaalAdres for klanten contacten and betrokkenen #212

Open
hsiliev opened this issue Aug 1, 2024 · 5 comments
Open

Expand DigitaalAdres for klanten contacten and betrokkenen #212

hsiliev opened this issue Aug 1, 2024 · 5 comments

Comments

@hsiliev
Copy link

hsiliev commented Aug 1, 2024

Thema / Theme

Klantinteracties API

Omschrijving / Description

We need only a few details of the data such as DigitaalAdres. To get email and phone, however we have to do multiple requests to the OpenKlant 2.1 API as this is not expand-ed neither in klanten contacten nor in betrokkenen

Toegevoegde waarde / Added value

Less requests to OpenKlant
Usage of already established mechanism with expand

Aanvullende opmerkingen / Additional context

We do have BSN or vestigingsnummer and want to enrich our data with information from OpenKlant.
So we do query for nummer and want to get the phone and email of the entity.

@hsiliev hsiliev added enhancement New feature or request triage labels Aug 1, 2024
@hsiliev
Copy link
Author

hsiliev commented Aug 6, 2024

This can be worked around using expand for Partij with betrokkenen,betrokkenen.hadKlantcontact,digitaleAdressen

The above feature request does not make much sense if primary search parameters (as in ZAC) are BSN and Vestigingsnummer

@joeribekker
Copy link
Member

@hsiliev I don't see the use case to expand partij all the way to betrokkene? DigitaleAdressen seems only relevant when expanding Partij or Betrokkene. However, for a Betrokkene, you can not search on BSN as these are non-authentic records.

@hsiliev
Copy link
Author

hsiliev commented Oct 22, 2024

We resorted to expanding Partij in our research to get to the email&phone data of the initiator. We need to scan all Betrokkene records, find the initiator and get its phone & email.

@joeribekker
Copy link
Member

joeribekker commented Jan 13, 2025

@hsiliev can you give us a sequence diagram or a list of calls that you do so we can more accurately determine how what we should do?

Do you want the DigitaleAdres expanded via the Betrokkene? Whats the call that you want to expand here?

@hsiliev
Copy link
Author

hsiliev commented Jan 13, 2025

For ZAC the way to get email & phone was to expand Partij toghether with expanding the betrokkenen inside, as we are doing a search by Partij anyway. This required manual patches to the generated client as per #216 though.

Getting the same info from Betrokkenen does not seems possible as one cannot expand it directly and this seems strange, hence this issue is just a feature request.

Priority for ZAC: Not urgent, not that important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

2 participants