Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate from templates #9

Open
irsdkv opened this issue Dec 20, 2019 · 3 comments
Open

Generate from templates #9

irsdkv opened this issue Dec 20, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@irsdkv
Copy link
Collaborator

irsdkv commented Dec 20, 2019

At this time we can go forward and implement generation from templates.
Hopefully I will return from my vacation in middle of January and will start that 😄
Additional info: #6

About API stabilization:
I think we can start as is and try new in process of templates generation implementation.
@julianoes @JonasVautherin if you will have any questions and suggestions related for current API (in develop branch) or any other - please create new issues or requests and I will try to answer as fast as possible

@irsdkv irsdkv added the enhancement New feature or request label Dec 20, 2019
@irsdkv irsdkv self-assigned this Dec 20, 2019
@danieleades
Copy link
Collaborator

out of curiosity, what is the benefit from this approach? what are you trying to achieve using the templates?

@irsdkv
Copy link
Collaborator Author

irsdkv commented Oct 22, 2021

I have no idea now, it was too late 😅

@JonasVautherin
Copy link
Collaborator

@danieleades The templates are used by protoc-gen-mavsdk to generate the code from the definitions in https://github.com/mavlink/mavsdk-proto.

The idea is that once you have written the templates, then all the changes coming in the core C++ implementation can propagate automatically to the language bindings. That's how we manage to keep MAVSDK-Java, MAVSDK-Python, MAVSDK-Swift up-to-date: most of the work is done in MAVSDK-C++.

Also note that historically we started by using gRPC to talk between MAVSDK-* and MAVSDK-C++, but it could use FFIs. I think it would actually be our preferred approach today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants