Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Error due to 'detect_missing_libraries' flag #722

Closed
2 tasks
Jrigada opened this issue Nov 11, 2024 · 1 comment
Closed
2 tasks

Confusing Error due to 'detect_missing_libraries' flag #722

Jrigada opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item

Comments

@Jrigada
Copy link
Contributor

Jrigada commented Nov 11, 2024

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

None

Describe the bug

When users set detect_missing_libraries = true in foundry.toml and attempt to compile contracts, a panic occurs due to missing bytecode in dual-compiled contracts. This issue arises because, with this flag enabled, zksolc outputs no bytecode, resulting in the dual-compiled contracts not being generated correctly.

To improve the user experience, we should enhance the error message shown when attempting to locate a contract with this flag enabled, or alternatively, consider a different strategy to ensure the error message provides clear guidance on the missing bytecode issue.

#710

@Jrigada Jrigada added bug 🐛 Something isn't working needs triage ♟️ Issue needs to be picked up or assigned labels Nov 11, 2024
@tomimor tomimor added the p3 🔵 Indicates low priority item label Nov 12, 2024
@MBerguer MBerguer self-assigned this Dec 26, 2024
@MBerguer
Copy link
Contributor

MBerguer commented Jan 8, 2025

This issue has transformed a little bit every time we have worked on supporting zksolc linking (#723, #40), and with every update for the compiler (#711), that it does not make any sense to throw an error, because in the next version of the compiler, all the missing libraries will be available directly in the output.
So, we are closing this in favor of #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item
Projects
None yet
Development

No branches or pull requests

3 participants