From d23d5c3462053ffcb4f395fe36303306b15e09a5 Mon Sep 17 00:00:00 2001 From: koloz Date: Wed, 24 Jan 2024 11:29:32 -0500 Subject: [PATCH] chore(contracts): removed todo comments --- l1-contracts/contracts/zksync/facets/Executor.sol | 1 - system-contracts/contracts/PubdataChunkPublisher.sol | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/l1-contracts/contracts/zksync/facets/Executor.sol b/l1-contracts/contracts/zksync/facets/Executor.sol index 7593c31c6..0f7b95056 100644 --- a/l1-contracts/contracts/zksync/facets/Executor.sol +++ b/l1-contracts/contracts/zksync/facets/Executor.sol @@ -41,7 +41,6 @@ contract ExecutorFacet is Base, IExecutor { // Get the chained hash of priority transaction hashes. LogProcessingOutput memory logOutput = _processL2Logs(_newBatch, _expectedSystemContractUpgradeTxHash); - // TODO: Adapt to handle dynamic number of blobs bytes32[] memory blobCommitments = new bytes32[](MAX_NUMBER_OF_BLOBS); bytes32[] memory blobHashes = new bytes32[](MAX_NUMBER_OF_BLOBS); if (pubdataSource == uint8(PubdataSource.Blob)) { diff --git a/system-contracts/contracts/PubdataChunkPublisher.sol b/system-contracts/contracts/PubdataChunkPublisher.sol index c75ff6615..4272a96b8 100644 --- a/system-contracts/contracts/PubdataChunkPublisher.sol +++ b/system-contracts/contracts/PubdataChunkPublisher.sol @@ -20,7 +20,7 @@ contract PubdataChunkPublisher is IPubdataChunkPublisher, ISystemContract { /// @dev We always publish 2 system logs even if our pubdata fits into a single blob. This makes processing logs on L1 easier. function chunkAndPublishPubdata(bytes calldata _pubdata) external onlyCallFrom(address(L1_MESSENGER_CONTRACT)) { require(_pubdata.length <= BLOB_SIZE_BYTES * MAX_NUMBER_OF_BLOBS, "pubdata should fit in 2 blobs"); - // TODO: Update for dynamic number of blobs + bytes32[] memory blobHashes = new bytes32[](MAX_NUMBER_OF_BLOBS); // We allocate to the full size of MAX_NUMBER_OF_BLOBS * BLOB_SIZE_BYTES because we need to pad