-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type declarations for TypeScript users #7
Comments
Hi Max! Thank you for your interest in this parser. Unfortunately, I’m not that familiar with TypeScript, but I’d gladly accept your pull request if you find the time to add those declarations. |
Hi! I've made a fork from this, and tried to convert it to TypeScript :) One additional thought: ➜ saxophone-ts git:(master)> npm run benchmark
> [email protected] benchmark /Users/gallayb/src/saxophone-ts
> node benchmark --unhandled-rejections=none
SaxophoneTs x 13,804 ops/sec ±0.77% (88 runs sampled)
Saxophone x 7,731 ops/sec ±0.68% (89 runs sampled)
EasySax x 8,725 ops/sec ±0.52% (89 runs sampled)
node-expat x 862 ops/sec ±0.57% (88 runs sampled)
libxmljs.SaxParser x 772 ops/sec ±0.50% (88 runs sampled)
sax-js x 857 ops/sec ±0.41% (87 runs sampled)
Fastest is SaxophoneTs |
@carathorys have you seen these changes since your last commit? @matteodelabre has fixed and improved some parts of the original JS code. Lets create types with https://github.com/microsoft/dts-gen |
@matteodelabre could you please merge these type definitions? |
@maxkreja try to use @matteodelabre could you please add benchmark comparison with |
Just install additional package and use Sax with types |
It would be nice to have type declarations for TypeScript for this parser. Unfortunately the JSDoc type declarations aren't enough for TypeScript to work.
I will create the declarations based on your code and submit a pull request when it's done.
The text was updated successfully, but these errors were encountered: