Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse proxy support #189

Open
yangm97 opened this issue Sep 25, 2021 · 0 comments
Open

Reverse proxy support #189

yangm97 opened this issue Sep 25, 2021 · 0 comments
Labels
feature New feature or functionality that didn't exist.

Comments

@yangm97
Copy link
Member

yangm97 commented Sep 25, 2021

When a request contains either the X-Forwarded-For or Forwarded headers and the originating host is trusted, the client IP should be derived from there instead.

There needs to be a configuration option for trusting IPs, subnets and a wildcard for when you can't know the proxy IP/range beforehand (i.e. AWS CloudFront).

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

https://symfony.com/doc/current/deployment/proxies.html

https://expressjs.com/en/guide/behind-proxies.html

@yangm97 yangm97 added the feature New feature or functionality that didn't exist. label Sep 25, 2021
jevolk added a commit to jevolk/charybdis that referenced this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality that didn't exist.
Projects
None yet
Development

No branches or pull requests

1 participant