Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes 1.2.0 is using Blackfriday V2 which uses modules dependency #79

Open
fmonod opened this issue Feb 11, 2021 · 1 comment
Open

Comments

@fmonod
Copy link

fmonod commented Feb 11, 2021

I'm currently using Hermes on a project that has some dependencies issues and cannot be used with modules at the moment.

Thing is, this hermes version supposedly supports the old dep system, but the ToHTML method (line 76) on hermes.go uses the blackfriday/v2 dependency which only works with modules and I can't make a proper build of my project without commenting it.

@adelcasse
Copy link

As a workaround, you could probably use a "replace" in your go.mod to handle this issue ?

Something like "replace gopkg.in/russross/blackfriday.v2 v2.1.0 => github.com/russross/blackfriday/v2 v2.1.0"

It seams to work on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants