Cannot use "tel:" links

[sklinkert]

I want to add a button containing a phone number linke this:

email := hermes.Email{}
email.Body.Actions = append(email.Body.Actions, hermes.Action{
	Instructions: lp.Sprintf("Use this button to call sender"),
	Button: hermes.Button{
		Color: "#57cbcc",
		Text:  "Call",
		Link: "tel:0123456789",
	},
})

This is what I get when I render the mail:

<a href="#ZgotmplZ" class="button" style="display:inline-block;border-radius:3px;font-size:15px;line-height:45px;text-align:center;text-decoration:none;-webkit-text-size-adjust:none;mso-hide:all;color:#ffffff;background-color:#57cbcc;width:200px" target="_blank" width="200">
Call
</a>

#ZgotmplZ is pretty unexpected. It works well with mailto: links.

I guess Go is treating tel: as unsafe content: https://stackoverflow.com/a/14796642/10385339

[matcornic]

Go officially considers tel as unsafe. Only http, https and mailto are supported

See discussions:

• html/template: clarify, perhaps expand allowed URLs in urlFilter  golang/go#20586

And documentation:

• https://go-review.googlesource.com/c/go/+/52853/3/src/html/template/url.go

[sklinkert]

Hmm I'm not really sure if a programming language should forbid things like this. I mean it's a tool. No more, no less. I think at the end it's up to the OS (if it's supporting phone calls) to decide if a phone number is evil and if it should block it or at least warn the user etc.

[DavidKittleSEL]

Hmm I'm not really sure if a programming language should forbid things like this. I mean it's a tool. No more, no less. I think at the end it's up to the OS (if it's supporting phone calls) to decide if a phone number is evil and if it should block it or at least warn the user etc.

Couldn't agree with you more. I am having the same problem with "file://" links. In the interim I have a simple workaround that seems to be working quite well.

fileLink := "file://server/share/folder/"
replaceMe := "https://replacethislink"

// Generate the email
h := hermes.Hermes{
	Product: hermes.Product{
		Name: "Awesome Email",
		Logo: "http://www.duchess-france.org/wp-content/uploads/2016/01/gopher.png",
	},
}

email := hermes.Email{
	Body: hermes.Body{
		Name: user,
		Intros: []string{
			"Interesting Title",
		},
		Actions: []hermes.Action{
			{
				Instructions: "Check out this working file:// link",
				Button: hermes.Button{
					Text: "File Link",
					Link: replaceMe,
				},
			},
		},
		Outros: []string{
			"Need help, or have questions? Just reply to this email, we'd love to help.",
		},
	},
}

emailBody, err := h.GenerateHTML(email)
if err != nil {
	fmt.Printf("Error while trying to generate email: %v", err)
}

emailBody = strings.ReplaceAll(emailBody, replaceMe, fileLink)