Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data attribute can not be set to null #682

Open
alexander-schranz opened this issue Jul 11, 2016 · 1 comment
Open

Data attribute can not be set to null #682

alexander-schranz opened this issue Jul 11, 2016 · 1 comment

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Jul 11, 2016

app.core.dom.data = function(selector, key, value) {

sandbox.dom.data($input, 'id', null) will just return the value and not set to null.

Possible Solution

if (typeof value === 'undefined') {
    // ...
} else {
    // ...
}
@alexander-schranz
Copy link
Member Author

@danrot @wachterjohannes currently I'm afraid to change this behaviour because this function could be missused currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant