Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable delegation of FASTAPI init arguments from RayCraftAPI #4

Open
marwan116 opened this issue Nov 5, 2023 · 0 comments
Open

enable delegation of FASTAPI init arguments from RayCraftAPI #4

marwan116 opened this issue Nov 5, 2023 · 0 comments

Comments

@marwan116
Copy link
Owner

current __init__ signature is

class RayCraftAPI:
    """RayCraftAPI class."""
    def __init__(self, **serve_deployment_kwargs):

Instead it should include both ray serve and fastapi kwargs - and ideally should have them spelled out for a friendlier interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marwan116