Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Shape Editor doesn't accept coordinates over 10,000,000 #341

Open
Blakepane opened this issue Mar 24, 2024 · 2 comments
Open

[Bug] Shape Editor doesn't accept coordinates over 10,000,000 #341

Blakepane opened this issue Mar 24, 2024 · 2 comments

Comments

@Blakepane
Copy link

Trying to input or use "Set Here" for a coordinate larger than +/-10,000,000 doesn't get accepted. Very niche scenario, but renders the Shape Manager useless if beyond 10,000,000.

minihud-fabric-1.20.4-0.30.2

@maruohon
Copy link
Owner

Which shape are you referring to?

The shapes have some limits for their maximum size, and I think at least some of them still tie the edit menu controls too directly to the actual shape values. Which means that if you for example need to set two corner points, it might reject the first one if it moves too much from the old values, before you even have the chance to set the other corner.

I think I fixed this recently for the Box shape for the 0.30.1 version, although I don't remember anymore how I did it and if it still would have this particular issue. Before it even had issues setting the corners at all even in small distances, depending on which corner you tried to move first or which one was on the negative side...

@Blakepane
Copy link
Author

I was mainly using Circle / Cylinder for testing, but I also tried different shapes too. I'm not sure if I changed something, though, because now the rendering is working as expected.

Regardless, the coordinate still doesn't show up in the box and is left blank despite rendering at the correct position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants