Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test docker images before pushing them #265

Open
martinthomson opened this issue Feb 9, 2021 · 2 comments
Open

Test docker images before pushing them #265

martinthomson opened this issue Feb 9, 2021 · 2 comments

Comments

@martinthomson
Copy link
Owner

This might require some tweaking, but it might be worth some automated testing of docker images before pushing them. Right now, that might just mean running the behave tests. Not sure about the archive scripts though, which were the cause of recent issues; those are not directly tested.

@MikeBishop
Copy link
Contributor

There are behave tests for the archive script in the archive repo. Maybe this is the time to switch over to pulling the archive tool from its own repo? Then you would just need some wiring to run those tests in your Docker container.

@martinthomson
Copy link
Owner Author

Maybe I can look at MikeBishop/archive-repo#2 and just go from there. At that point, I don't need to worry about getting the dependencies right. I do have testing that uses the core docker image, it's just that those tests run after any bugs hit production code, which is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants