Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Description for Setting: Markdown › Marp: Themes #344

Open
ludos1978 opened this issue Apr 19, 2022 · 3 comments
Open

Better Description for Setting: Markdown › Marp: Themes #344

ludos1978 opened this issue Apr 19, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@ludos1978
Copy link

The description in "Markdown › Marp: Themes"

is currently:
A list of URLs or local paths to additional theme CSS for Marp core and Marpit framework. The rule for paths is following Markdown: Styles.

what is missing:
the local path must be relative, it cannot be an absolute path. This is described in the documentation, but not in the vs-code plugin itself.

should be:
A list of URLs or local relative paths to additional theme CSS for Marp core and Marpit framework. The rule for paths is following Markdown: Styles.

@yhatt
Copy link
Member

yhatt commented Apr 19, 2022

Marp has no duplicated description because a linked VS Code built-in setting Markdown: Styles has already described about them. By clicking the hyperlink, user can see a detailed rule of paths.

A list of URLs or local paths to CSS style sheets to use from the Markdown preview. Relative paths are interpreted relative to the folder open in the Explorer. If there is no open folder, they are interpreted relative to the location of the Markdown file. All '' need to be written as '\'.

Having said that, making clear that the path is relative is better than the current description. A pull request is welcome 😃

@GoBigorGoHome
Copy link

It seems that a local path to theme CSS not only has to be relative, but also it cannot begin with ../ which refers to the parent directory.

@yhatt
Copy link
Member

yhatt commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants