Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated PPTX is creating Master Slides, not Slides (as I was hoping) #166

Closed
richbrooks opened this issue Oct 1, 2019 · 2 comments · Fixed by #205 · May be fixed by #626
Closed

Generated PPTX is creating Master Slides, not Slides (as I was hoping) #166

richbrooks opened this issue Oct 1, 2019 · 2 comments · Fixed by #205 · May be fixed by #626

Comments

@richbrooks
Copy link

The PPTX output is awesome, but I am having an issue with 2 features. If this is explained somewhere, can you please point me to it.

1- The generated slides are actually creating unique Master Slides and then the slide on the front end is using that Master Slide Template (for example, Slide 1 is using Master Slide 1 and Slide 2 is using Master Slide 2). I was hoping that it would generate a regular slide. There is probably a good reason for this. The secondary issue with this, is if we actually apply a Master Theme to the Slide Deck, the elements of the Master Theme sit on top of the text/table/etc generated by MARP.

  1. Somewhat related to number 1 (as in this is the PPTX generated content). The Slide contents are not editable after the fact. It is some sort of uneditable background image. Even on the Master Slide, I can't edit the contents. Is there a switch or something to output editable text. Going to reboot my machine to see if there is something just not acting right.

By the way, don't take this as negatives. I freaking love the project. Thank you for all of your effort.
@yhatt yhatt transferred this issue from marp-team/marp-vscode Oct 1, 2019
@yhatt
Copy link
Member

yhatt commented Oct 1, 2019 •
edited
Loading

PPTX export is essentially the feature of Marp CLI. I've translated issue from Marp for VS Code ➡️ Marp CLI 🚚

  1. It is caused by restriction from using JS library (PptxGenJS). The rendered slide will set as background image. It's the same approach with GitPitch (Try to open sample slide deck), and better for annotatation in presentation tools. But PptxGenJS has not supported setting per slide background images. Creating a lot of master slides is the only way, and we had no choice at this time.

  2. Marp focuses to keep beautiful looking slides regardless of the kind of conversion. Rendering images is the best way for that. Creating editable PPTX is very hard because it's like re-creation of HTML rendering engine. Perhaps it would be much larger project than Marp.

If you want editable PPTX, we recommend to convert exported PDF into PPTX by Adobe Acrobat. However, I suppose the reproducibility of output is not good even if this. (different fonts, incorrect shadow rendering, etc...)

Current PPTX generation
(Not editable / Perfect reproducibility)		 PDF -> PPTX by Adobe Acrobat
(Editable / Incorrect renderings)
marp-pptx adobe-acrobat

In short, now the editable PPTX with quality that Marp required cannot generate in any way. I'd like you to think it's the result after doing the best for PPTX generation.

@yhatt yhatt mentioned this issue Jan 6, 2020
Closed
@yhatt yhatt mentioned this issue Feb 23, 2020
Merged
@yhatt
Copy link
Member

yhatt commented Feb 23, 2020

1 was improved by working in #205. A single master slide would be applied to PPTX creation in the future release.

@yhatt yhatt mentioned this issue Apr 20, 2020
Closed
@yhatt yhatt mentioned this issue Jul 16, 2020
Closed
@yhatt yhatt mentioned this issue Aug 1, 2020
Merged
@yhatt yhatt mentioned this issue Nov 10, 2020
Closed
@yhatt yhatt mentioned this issue Dec 26, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yhatt @richbrooks