Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move last-cache, -mirror, etc. into setup.rc #18

Open
maphew opened this issue Nov 24, 2014 · 4 comments
Open

Move last-cache, -mirror, etc. into setup.rc #18

maphew opened this issue Nov 24, 2014 · 4 comments
Labels
enhancement
Milestone
Osgeo.org release...

Comments

@maphew
Copy link
Owner

maphew commented Nov 24, 2014

Setup.exe has moved it's settings for last-mirror, last-cache, etc. into a single file: ./etc/setup/setup.rc. We need to do the same to maintain compatibility.

mirrors-lst
    http://download.osgeo.org/osgeo4w/;OSGeo;USA;California
window-placement
    44,0,0,0,0,0,0,0,1,0,0,0,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,151,1,0,0,185,0,0,0,185,3,0,0,72,2,0,0
last-mode
    Advanced
last-mirror
    http://download.osgeo.org/osgeo4w/
net-method
    Direct
last-cache
    C:\Users\Matt\Downloads
last-menu-name
    OSGeo4W_default
@maphew maphew added this to the Dec2014 osgeo.org release milestone Nov 24, 2014
maphew added a commit that referenced this issue Nov 30, 2014
@maphew
reminder: only half-done #18
a29671c
maphew added a commit that referenced this issue Dec 1, 2014
@maphew
#18: write setuprc to disk, brokenish
c043971 
Func exists, but isn't being triggered with `apt update`, but is on `apt
download ...`. At moment it writes to a test file, and this works. What
I'm not sure about is if it's okay to write "None" to the rc file, or
if it should just be silent if it doesn't have a real value. Todo: ask
@jef-n.
@maphew
Copy link
Owner Author

maphew commented Dec 1, 2014

@jef-n, I'm 3/4ths through adapting apt to read and write etc/setup/setup.rc. On write, I want to make sure I don't mess up Setup.exe. What happens when it encounters an unexpected value? I'm thinking the most likely one would be 'None', which would occur if a person installs osgeo4w with an apt-from-scratch, followed by Setup.exe.

mirrors-lst
        None
window-placement
        None
last-mode
        None
last-mirror
        http://download.osgeo.org/osgeo4w/
net-method
        None
last-cache
        C:\Users\Matt\Downloads
last-menu-name
        OSGeo4W_default

Should I leave this as is, write the None's as blank lines instead, or just leave the empty entries out entirely?

maphew added a commit that referenced this issue Dec 2, 2014
@maphew
#18: write_setuprc() now close to final
ed9a4ad 
* extend docstring, remove test fname
+ leave out empty values completely
+ update rc dict from globals (note: these globals are still being read
  from the old non-rc config files though!)
@maphew maphew mentioned this issue Apr 4, 2015
Open
@amr66
Copy link
Contributor

amr66 commented Apr 4, 2015

Take the Setup.exe, Install a small package and use the values written...

@amr66
Copy link
Contributor

amr66 commented Apr 9, 2015

What exactly is missing with setup.rc?

@maphew
Copy link
Owner Author

maphew commented Apr 25, 2015

As I recall saving the globals to the rc file works, but at startup the rc file is ignored. So if someone runs Setup.exe and chooses different values, Apt will overwrite them from the older pre-rc cache files. I haven't tested what happens when the old cache files don't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Osgeo.org release (0.3-2?)
Development

No branches or pull requests
2 participants
@maphew @amr66