Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip and report, or improved logging of failed tiles. #225

Open
agoddard opened this issue Apr 3, 2021 · 1 comment
Open

Option to skip and report, or improved logging of failed tiles. #225

agoddard opened this issue Apr 3, 2021 · 1 comment

Comments

@agoddard
Copy link

agoddard commented Apr 3, 2021

👋 When running tilelive-copy --scheme=list --list=/list_of_tiles.txt I occasionally see the following error, which stops tilelive-copy from any further processing of the list_of_tiles.txt list :

   if (err) throw err;
                 ^

TypeError: required parameters (z, x, and y) must be greater then or equal to zero
    at TypeError (native)
    at Function.Bridge.getVector (/usr/local/lib/node_modules/tilelive-bridge/index.js:243:21)
    at /usr/local/lib/node_modules/tilelive-bridge/index.js:185:20
    at dispense (/usr/local/lib/node_modules/tilelive-bridge/node_modules/generic-pool/lib/generic-pool.js:258:16)
    at Object.me.release (/usr/local/lib/node_modules/tilelive-bridge/node_modules/generic-pool/lib/generic-pool.js:368:5)
    at /usr/local/lib/node_modules/tilelive-bridge/index.js:282:21

I've inspected my tiles list a number of ways and I can't determine the problematic tile, so it would be helpful to have a --skip-failed-tiles flag, or similar, which would simply move on to the next tile (while outputting the failed tile info) and/or a --debug / --verbose flag to print out the current tile that's being processed, so it's easier to debug when this case occurs.

I can work on a PR for either/both, would love opinions on whether this approach would be sensible/helpful.

Thanks!

@agoddard
Copy link
Author

agoddard commented Apr 9, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant