Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global leaks #178

Open
tjwebb opened this issue Sep 1, 2016 · 1 comment
Open

global leaks #178

tjwebb opened this issue Sep 1, 2016 · 1 comment

Comments

@tjwebb
Copy link

tjwebb commented Sep 1, 2016 •
edited
Loading

When I have mocha check for global leaks, it reports this:

     Error: global leaks detected: tileliveProtocols, __core-js_shared__

Why does tilelive insert values into the global namespace? This is bad practice, and I've never seen mocha throw this error with any other node module.
@tjwebb
Copy link
Author

tjwebb commented Sep 2, 2016

Right here: https://github.com/mapbox/tilelive/blob/master/lib/tilelive.js#L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjwebb