Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NN patch #7567

Merged
merged 2 commits into from
Oct 18, 2023
Merged

NN patch #7567

merged 2 commits into from
Oct 18, 2023

Conversation

DzmitryFomchyn
Copy link
Contributor

Description

This PR bumps NN to 160.0.1

@DzmitryFomchyn DzmitryFomchyn added the skip changelog Should not be added into version changelog. label Oct 18, 2023
@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner October 18, 2023 07:09
@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Changelog

Features

Bug fixes and improvements

  • Fix an issue where not all fields of incident were converted to JSON properly. [#7567](https://github.com/mapbox/mapbox-navigation-android/pull/7567)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@DzmitryFomchyn DzmitryFomchyn removed the skip changelog Should not be added into version changelog. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #7567 (9793859) into release-v2.17 (db024b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release-v2.17    #7567   +/-   ##
================================================
  Coverage            74.15%   74.15%           
  Complexity            6153     6153           
================================================
  Files                  830      830           
  Lines                32936    32936           
  Branches              3930     3930           
================================================
  Hits                 24424    24424           
  Misses                6978     6978           
  Partials              1534     1534

dzinad
dzinad reviewed Oct 18, 2023
View reviewed changes
changelog/unreleased/bugfixes/7567.md
@@ -0,0 +1 @@
- Fix an issue where not all fields of incident were converted to JSON properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed an issue where some of the incident fields might have been lost after refresh.

@DzmitryFomchyn DzmitryFomchyn enabled auto-merge (squash) October 18, 2023 10:16
@VysotskiVadim VysotskiVadim mentioned this pull request Oct 18, 2023
Merged
@VysotskiVadim VysotskiVadim merged commit 1cad51f into release-v2.17 Oct 18, 2023
6 of 8 checks passed
@VysotskiVadim VysotskiVadim deleted the df-2_17-patch branch October 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzinad dzinad dzinad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DzmitryFomchyn @dzinad @VysotskiVadim