Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on saving mantid project #38655

Open
GuiMacielPereira opened this issue Jan 21, 2025 · 0 comments
Open

Crash on saving mantid project #38655

GuiMacielPereira opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone

Comments

@GuiMacielPereira
Copy link
Contributor

Describe the bug
Trying to save mantid project for the first time with Save altered workspaces only creates a crash.

To Reproduce

  • Load CNCS_7860_event from training data
  • Go to File > Save project
  • Tick Save altered workspaces only
  • Pick a new path for the project (choose a new name)
  • Click OK

You should be presented with the following error:

Traceback (most recent call last):
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/widgets/saveprojectdialog/presenter.py", line 66, in save_as
    self.project.save_as(path=self.view.get_location())
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/project/project.py", line 109, in save_as
    task.start()
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/utils/asynchronous.py", line 148, in start
    raise self.recv.exc_value
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/utils/asynchronous.py", line 63, in run
    out = self.target(*self.args, **self.kwargs)
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/project/project.py", line 139, in _save
    workspaces_to_save = self._filter_unaltered_workspaces(workspaces_to_save)
  File "/home/ljg28444/mambaforge/envs/mantid-6.12-mtest/lib/python3.10/site-packages/mantidqt/project/project.py", line 194, in _filter_unaltered_workspaces
    if not (history.size() == 1 and history.getAlgorithm(0).name() == "Load"):
RuntimeError: Unknown property search object 'LoadMonitors'

This bug was already present in 6.11 and so it is not a regression.

Expected behavior
The project is saved successfully or at least the error is handled and an error message is displayed.

Screenshots

Platform/Version (please complete the following information):

  • OS: Ubuntu 20.04
  • OS Version: 20.04
  • Mantid Version 6.12

Additional context
@jclarkeSTFC tried it on Windows and managed to also reproduce it.

@GuiMacielPereira GuiMacielPereira added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Jan 21, 2025
@GuiMacielPereira GuiMacielPereira added this to the Release 6.13 milestone Jan 21, 2025
@jclarkeSTFC jclarkeSTFC added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Jan 21, 2025
@sf1919 sf1919 modified the milestones: Release 6.13, Release 6.12 Jan 22, 2025
@sf1919 sf1919 moved this to Assigned in v6.12 release Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: No status
Status: Assigned
Development

No branches or pull requests

4 participants