Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken auto-schema after changes in Manticore #372

Open
3 of 5 tasks
donhardman opened this issue Oct 11, 2024 · 4 comments
Open
3 of 5 tasks

Broken auto-schema after changes in Manticore #372

donhardman opened this issue Oct 11, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@donhardman
Copy link
Contributor

donhardman commented Oct 11, 2024

Bug Description:

There is an issue with CI, and tests are failing for auto schema.

Here is the pipeline: https://github.com/manticoresoftware/manticoresearch-buddy/actions/runs/11211972076/job/31397270089

After a brief investigation, it looks like the changes in the SQL endpoint caused it, but we're still not sure.

Tests fail on: Manticore 6.3.7 a8991355d@24101013 dev (columnar 2.3.1 30ad2d6@24100914) (secondary 2.3.1 30ad2d6@24100914) (knn 2.3.1 30ad2d6@24100914)

Tests succeed on: Manticore 6.3.7 39f0c0456@24100706 dev (columnar 2.3.1 3c05f76@24100109) (secondary 2.3.1 3c05f76@24100109) (knn 2.3.1 3c05f76@24100109)

We should investigate and find the root cause.

Manticore Search Version:

Latest dev version

Operating System Version:

Ubuntu Jammy

Have you tried the latest development version?

None

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@Nick-S-2018
Copy link
Contributor

Nick-S-2018 commented Oct 14, 2024

The issue can be reproduced with Manticore 6.3.7 a8991355d@24101013 dev. It does seem to be related to the changes in how daemon handles Buddy sql endpoints.

curl localhost:9308/sql?mode=raw -d 'show tables'
[{
"columns":[{"Index":{"type":"string"}},{"Type":{"type":"string"}}],
"data":[

],
"total":0,
"error":"",
"warning":""
}]

curl localhost:9308/sql?mode=raw -d 'insert into test(a) values(1)'
{"error":"table 'test' absent, or does not support INSERT"}

But, in fact, the insert request has been executed properly:

curl localhost:9308/sql?mode=raw -d 'select * from test'
[{
"columns":[{"id":{"type":"long long"}},{"a":{"type":"long"}}],
"data":[
{"id":6704245913751126018,"a":1}
],
"total":1,
"error":"",
"warning":""
}]

@Nick-S-2018 Nick-S-2018 assigned tomatolog and unassigned Nick-S-2018 Oct 14, 2024
@tomatolog tomatolog assigned Nick-S-2018 and unassigned tomatolog Oct 15, 2024
@tomatolog
Copy link
Contributor

fixed at manticoresoftware/manticoresearch@85f4b76

@PavelShilin89 should add the CLT test case like

mysql -h 127.0.0.1 -P 9306 -e "drop table test"
curl -X POST "localhost:9308/sql?mode=raw" -d "insert into test(a) values(1)"
mysql -h 127.0.0.1 -P 9306 -e "select * from test"

the curl should not return error message then select should returns the document

@PavelShilin89
Copy link

Testing performed in PR - manticoresoftware/manticoresearch#2664
@donhardman - please consider this PR.
In table test2, the values for the vector field, which were inserted as (0.1, 0.2, 0.3, 0.4) and (0.5, -0.3, 0.9, -0.1), are returned as zeros 0,0,0,0. This indicates an issue with either the storage or interpretation of the vector data.

@PavelShilin89
Copy link

Blocked by #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants