Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer function in propagation appears to be incorrect #453

Open
Tracked by #427
vnmanoharan opened this issue Dec 17, 2024 · 0 comments
Open
Tracked by #427

Transfer function in propagation appears to be incorrect #453

vnmanoharan opened this issue Dec 17, 2024 · 0 comments
Assignees
Milestone

Comments

@vnmanoharan
Copy link
Contributor

This line in convolution_propagation.py is supposed to set the transfer function to be zero at all nonphysical spatial frequencies. But we previously set the root variable equal to zero wherever it is negative (that is, wherever taking sqrt(root) would result in an imaginary value). So the line g = g * (root >= 0) will not actually do anything! The transfer function remains unchanged because root >= 0 everywhere, and at the points where root = 0, the transfer function will be equal to 1, which is incorrect. This line should read g = g * (root > 0) instead.

Need to fix and include a test against known transfer functions.

@vnmanoharan vnmanoharan added this to the 3.6 milestone Dec 17, 2024
@vnmanoharan vnmanoharan self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant