Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow downloading all albums #128

Closed
tymmej opened this issue Feb 24, 2023 · 1 comment · Fixed by #146
Closed

[FEATURE] Allow downloading all albums #128

tymmej opened this issue Feb 24, 2023 · 1 comment · Fixed by #146
Assignees
Labels
new feature New feature or request
Milestone

Comments

@tymmej
Copy link
Contributor

tymmej commented Feb 24, 2023

Describe the bug
Downloading photos without filters["albums"] downloads only main (pseudo)folder with all photos.

Logs show misleading information:

2023-02-24 19:14:49,881 :: WARNING :: root :: config_parser.py :: 287 :: photos > filters > albums not found. Downloading all albums ...

It's Downloading "all" album where "all" is (pseudo)album, not all albums which are user created albums.

To Reproduce
Run docker without without filters["albums"] on library with user defined albums.

Expected behavior
Without filter["albums"] download all albums as log suggests.
Alternatively, allow "*" in filter["albums"] to really download all albums.

Screenshots
Not applicable.

Configuration
As described in previous points.

Additional context
Similar loop to https://github.com/mandarons/icloud-drive-docker/blob/33d5683aa22e106c8e9de0985c8bf49117bc4a36/src/sync_photos.py#L116 should be added to else path with for album in photos.albums.keys(). Or another option is to do that in first path under * wildcard in config.

Storage is cheap, I don't care about duplication of photos which are in multiple albums (All, Favorites, grouped by event, Live Photos...).

@tymmej tymmej added the bug Something isn't working label Feb 24, 2023
@tymmej tymmej changed the title [BUG] Allow downloading all albums [FEATURE] Allow downloading all albums Mar 4, 2023
@tymmej
Copy link
Contributor Author

tymmej commented Mar 4, 2023

In #130 I added version without unit tests. As I said I do not know how to mock data for Smart Albums.

@mandarons mandarons added new feature New feature or request and removed bug Something isn't working labels Sep 24, 2023
@mandarons mandarons added this to the 1.15.0 milestone Sep 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Incoming in Backlog Sep 24, 2023
@mandarons mandarons moved this from 🆕 Incoming to 🏗 In progress in Backlog Sep 24, 2023
@mandarons mandarons linked a pull request Sep 26, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Backlog Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants