Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement different levels of "make clean" #38

Open
ezzatron opened this issue Feb 4, 2020 · 5 comments
Open

Implement different levels of "make clean" #38

ezzatron opened this issue Feb 4, 2020 · 5 comments

Comments

@ezzatron
Copy link
Member

ezzatron commented Feb 4, 2020

In previous implementations of the makefiles, we used to have make clean and make clean-all. A similar concept might be useful here.

Two things stand out as being potential candidates to not remove under the standard make clean target:

  • Dependencies (e.g. node_modules / vendor directories)
  • The .makefiles directory itself

Implementing this might solve #36, which we currently think is caused by the .makefiles directory being removed before some of the double-colon clean:: targets run.

The question is: what to call these different targets, and what should be cleaned by each?

@ezzatron
Copy link
Member Author

ezzatron commented Feb 4, 2020

@jmalloc FYI

@jmalloc
Copy link
Contributor

jmalloc commented Nov 22, 2020

I've going to go ahead and at least remove .makefiles from clean, this has been pretty useful for a while with that in there.

@jmalloc
Copy link
Contributor

jmalloc commented Nov 22, 2020

Spoke to soon, easier said than done, etc - https://github.com/make-files/lib-core/blame/v1/include/common.mk#L99

@jmalloc
Copy link
Contributor

jmalloc commented Nov 22, 2020

I guess we just add .makefiles to CLEAN_EXCLUSIONS by default?

@ezzatron
Copy link
Member Author

Could work well in combo with a self-update target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants