Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle for errors in transport #10

Open
Nightbr opened this issue Dec 19, 2017 · 0 comments
Open

Better handle for errors in transport #10

Nightbr opened this issue Dec 19, 2017 · 0 comments

Comments

@Nightbr
Copy link
Member

Nightbr commented Dec 19, 2017

I think we should throw runtime error and only catch Mailjet API error. Because when we have a real issue (mailjet/mailjetBundle#10 with curl), we need to be alerted that there is an error...

Lets think about this.

https://github.com/mailjet/MailjetSwiftMailer/blob/master/SwiftMailer/MailjetTransport.php#L146 We can be more precise on the type of error we catch here. Also I think we should look at SwiftMailer recommendation and best practice on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant