Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show last sso login in mailbox table #5724

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

q16marvin
Copy link
Contributor

Hi,

please don't hit me, thats my first PR...

i would love to see not only last imap, pop3 or smtp login. i also want to see last sso login. the timestamps are currently saved in the mysql db, but until know it was not possible to see in the gui or via api.

with this small changes we can see :)

Thx!

Erik

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@q16marvin q16marvin changed the base branch from master to staging February 9, 2024 10:27
@FreddleSpl0it
Copy link
Collaborator

Thanks for the PR. looks good so far, but could you please use the staging branch as a base for your changes?
https://github.com/mailcow/mailcow-dockerized/blob/master/CONTRIBUTING.md

@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Apr 15, 2024
@milkmaker milkmaker closed this Apr 22, 2024
@FreddleSpl0it FreddleSpl0it reopened this Aug 13, 2024
@milkmaker milkmaker removed the stale Please update the issue with current status, unclear if it's still open/needed. label Aug 13, 2024
@FreddleSpl0it FreddleSpl0it merged commit b1368d2 into mailcow:staging Sep 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants