Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically choose the Docker network subnet #4879

Closed
wants to merge 1 commit into from
Closed

Dynamically choose the Docker network subnet #4879

wants to merge 1 commit into from

Conversation

Abbas-b-b
Copy link

Resolves #4878

@DerLinkman DerLinkman added this to the 2023 milestone Jan 17, 2023
@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label Mar 18, 2023
@Abbas-b-b
Copy link
Author

Do I need to do anything about it?

@milkmaker milkmaker removed the stale Please update the issue with current status, unclear if it's still open/needed. label Mar 20, 2023
@DerLinkman
Copy link
Member

Hi there,

nope. No need for you by now.

A test is needed which i'll do today i think.

@milkmaker
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@milkmaker milkmaker added the stale Please update the issue with current status, unclear if it's still open/needed. label May 19, 2023
@milkmaker milkmaker closed this May 26, 2023
@cl445
Copy link

cl445 commented Jul 7, 2024

The current script attempts to generate a new Docker network subnet by incrementing the highest octet found in existing subnets. However, if the highest octet is 255, the script produces an invalid subnet, 172.256.., which falls outside the valid IP range.

@cl445
Copy link

cl445 commented Jul 7, 2024

This PR addresses bug #4878 only partially! The script potentially generates a valid Docker network only once during the installation of Mailcow. However, if Docker is restarted (e.g., after an update), conflicts may arise again because Docker dynamically creates a network that conflicts with the one created by generate_config.sh .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs testing stale Please update the issue with current status, unclear if it's still open/needed.
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.
4 participants
@Abbas-b-b @milkmaker @DerLinkman @cl445