Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of ED25519-SHA256 for signing DKIM Keys #2972

Open
saldru opened this issue Sep 24, 2019 · 7 comments
Open

Add support of ED25519-SHA256 for signing DKIM Keys #2972

saldru opened this issue Sep 24, 2019 · 7 comments
Assignees

Comments

@saldru
Copy link

saldru commented Sep 24, 2019

Hi everyone,

I ask for a feature that could be interesting. Actually the mailCow suite only support DKIM keys signed with RSA through the web UI. Since 04/02/2019, Rspamd added support for signing DKIM keys with ED25519 with SHA256 regarding the new RFC 8463.

So it could be good to add the option of generating/importing and supporting DKIM keys signed with ED25519-SHA256 in addition of RSA keys.

Thank you for you time :)
Saldru

@andryyy
Copy link
Contributor

andryyy commented Sep 24, 2019

I will add it as FR, but I don't think we will add it very soon. Not many servers can actually validate them, btw.

We could double-sign, but that's just overly complicated for most people running a mailcow. Same with this multi-cert stuff with RSA and ECDSA. Multiple different TLSA records per domains sound fun for most people, who chose mailcow to reduce the hassle.
We will eventually move forward, yes, but I don't think we should add more hacky solutions for something not yet fully supported or established.

I think DKIM with ED25519 is not too far away though. :)

Thanks for your FR!

@saldru
Copy link
Author

saldru commented Sep 24, 2019

Hi @andryyy,
thank you for your reply !

Yeah I know that it's new and it's better for mails when the policy is the most open and not too "modern" to be able to receive and send mail from/to everyone. :)

But I think it's a feature that can say to everyone that "mailcow support it !" and yeah I know it's not in the top of priority. :)

@ghost
Copy link

ghost commented May 12, 2021

I think DKIM with ED25519 is not too far away though. :)

@andryyy Is support for signing mails with ED25519 DKIM keys still on the roadmap for mailcow?

@andryyy
Copy link
Contributor

andryyy commented May 12, 2021

Yes, in the future. We will do dual signing at some point.

As of today it is pretty much not checked at all...

@andryyy
Copy link
Contributor

andryyy commented Jun 3, 2021

It is.

@andryyy andryyy self-assigned this Jun 3, 2021
@JJ1LFC
Copy link

JJ1LFC commented Jan 23, 2024

Hi, It's been 4yrs now. We should not keep messing up our TXT RR with very long RSA 1024/2048 bit pubkey - or should we go to RSA 4096 seriously? It's a stupid idea. Let's boost the entire world to use shorter elliptic curve algo.

@martinjgrunwald
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants