Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify whitelist config #10

Open
2 tasks done
pkosiec opened this issue Dec 18, 2018 · 1 comment
Open
2 tasks done

Simplify whitelist config #10

pkosiec opened this issue Dec 18, 2018 · 1 comment

Comments

@pkosiec
Copy link

pkosiec commented Dec 18, 2018

Confirm these statements before you submit the issue:

  • I have searched open and closed issues for duplicates.
  • I have read the contributing guidelines.

Description

Hi @magicmatatjahu,
First of all: Great tool!

I have an idea for simplifying the whitelist config. Currently we have:

  - path: "path"
    config:
      white-list-internal: ["./test.md"]
      white-list-external: ["https://foo.bar"]

Can't we have just whitelist key?

  - path: "path"
    config:
      whitelist: ["./test.md", "https://foo.bar"]

Sometimes we have false positives, which we doesn't know whether they are classified as internal or external links.

Thanks!

@magicmatatjahu
Copy link
Owner

Hi @pkosiec
Thanks you for using milv tool.
I want to do something similar to what you proposed, but in version 0.1.0. For now, I do not have much time to do that, but If you want, feel welcome to contribute. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants