Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems that the poster for the video does not update when the video ID is changed. This could lead to confusion for users. #4313

Open
8 tasks
arvind-netzwelt opened this issue Aug 14, 2024 · 6 comments
Assignees
Labels
bug Something isn't working issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing Issue: Needs Update Additional information is require, waiting for response Progress: ready for grooming

Comments

@arvind-netzwelt
Copy link

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
I have used Venia PWA with Magento 2. I have used React-player to show a YouTube video. If I change the YouTube video in Magento, the poster of the video does not change. However, in GraphQL, the ID of the video is changed. How can this be handled?

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Possible solutions

Add any ideas about possible solutions to the problem here.

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version [e.g Adobe Commerce 2.4]:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@arvind-netzwelt arvind-netzwelt added the bug Something isn't working label Aug 14, 2024
Copy link

m2-assistant bot commented Aug 14, 2024

Hi @arvind-netzwelt. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@glo82145
Copy link
Collaborator

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3357 is successfully created for this GitHub issue.

@del15881
Copy link
Collaborator

@arvind-netzwelt hi, we'd like more information on this issue. We tried to add a video to the PWA venia-storefront using Magento Admin pagebuilder. We then replaced the first video URL with a new one and refreshed the cache from Magento admin and then checked the PWA-frontend and the Banner updated correctly for us.

Do you have any specific steps to recreate the issue ?

@del15881 del15881 added the Issue: Needs Update Additional information is require, waiting for response label Oct 24, 2024
@glo42707 glo42707 added issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing and removed Progress: ready for grooming labels Oct 24, 2024
@arvind-netzwelt
Copy link
Author

I have added the code like this, youtubeCaption changed on Graphql but not changed on frontend. after clear the browser cookies its working fine

<ReactPlayer
key={${youTubeUrl}-${youtubeCaption}}
width="100%"
height={isDesktop ? '400px' : '200px'}
url={youTubeUrl}
playing={playing}
className={classes.modalVideo}
controls={false}
light={youtubeCaption || true}
playIcon={

}
/>

@del15881
Copy link
Collaborator

Hey @arvind-netzwelt , Thank you for your response. As part of our current process, we are unable to accommodate requests for custom code changes directly. However, we welcome and encourage contributions from community members who are interested in supporting code enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working issue: Cannot Reproduce when issue not reproducible by internal team they might required additional info or steps missing Issue: Needs Update Additional information is require, waiting for response Progress: ready for grooming
Projects
None yet
Development

No branches or pull requests

5 participants