-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionalFeature: respectDoNotDisturb #98
Comments
I think this would be a very welcomed feature and I think this is good engineering personally. Be persistent in the messaging around updating, but clever programming to avoid pop ups at the wrong time. I know end users that respect this kind of approach to updates, but if it's a bad experience you've lost them. Hope you get some help on this one! |
This would be fantastic - unfortunately my swift ability is fairly poor. maybe i can see how you can query if do not disturb is currently enabled or disabled? |
This is as close as I got to getting it working. Works in macOS 11 but due to changes in the way DND is implemented in macOS 12 (essentially it's per app DND, not on or off) the DND state is not readable from the ncprefs plist. There may be a way to read state from icloud data as that's where focus settings seems to be stored but I'm yet to work that out. import SystemConfiguration
func isDNDEnabled() -> Bool {
// check for DND and return true if it is on
// ** This function will not work under macOS 12 as at July 2021
let consoleUser = SCDynamicStoreCopyConsoleUser(nil, nil , nil)
let consoleUserHomeDir = FileManager.default.homeDirectory(forUser: consoleUser! as String)?.path ?? ""
let ncprefsUrl = URL(
fileURLWithPath: String("\(consoleUserHomeDir)/Library/Preferences/com.apple.ncprefs.plist")
)
do {
let prefsList = try plistFromData(try Data(contentsOf: ncprefsUrl))
let dndPrefsData = prefsList["dnd_prefs"] as! Data
let dndPrefsList = try plistFromData(dndPrefsData)
if let userPref = dndPrefsList["userPref"] as? [String:Any] {
return userPref["enabled"] as! Bool
}
} catch {
// prefs weren't readable. quit or do somethhing else here
print("DND Prefs Not Available")
}
return false
} |
Fun |
I might have found a way to check focus mode under macOS 12 using the requires adding the I want to use this in my own app but as it's a CLI utility it appears I can't add the entitlement :( |
Minor update to this - once Xcode supports the in terms of an implementation though, a question would be would you want it to honour DND by default or would you want it to continue the existing behaviour and make respecting DND an options to be enabled? |
Excellent find, @bartreardon. IMHO, this feature should default to |
I made a proof of concept app that reports back DND status on macOS 11 and 12 https://github.com/bartreardon/infocus - waiting for the prod release of xcode 13 with these frameworks for macOS 12 included. |
This should be optional and not default behavior. I don't believe in respecting DND Nudge/UMAD. UMAD takes it a step further and disables DND to ensure the DEP nag window shows up. |
@erikng Note: If possible merely having such an app running would not cause Nudge to not trigger but only if a PowerPoint presentation is running or a video call is in progress. Since the macOS screensaver respects such behaviour clearly this is possible. |
@jelockwood @sphen13 @redshirtdave @erikng @dan-snelson @bartreardon I'm combing the desert of issues for clues... and I would not recommend any option to respect Do-Not-Disturb for a couple of reasons:
|
I have ran into an interesting set of issues supporting this. The code was simple, but it requires an entitlement and that entitlement requires a provisioning profile. At some point, someone (unknown who atm) took There are two more potential paths about who could have this AppID
I'm hoping it's Uber because CDO's Developer ID expired and we would have to spend money just to potentially get a solution here. So I'm re-opening #453 and putting a warning out now: If I can't solve this, the only way to implement this code will be by changing the Bundle ID of Nudge. |
I think for now I am going to close this. I tried just now with the io.macadmins.Nudge identifier and ran into even more problems here.
This feature just isn't work the headaches, legal liability and ramifications of this. Blame Apple for not better supporting open source. |
There might be a small group of admins who actually want to respect DND settings.
Unless this is trivial to implement, I won't be writing this feature, so I am marking this as
help wanted
The text was updated successfully, but these errors were encountered: