Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] Logical operators should be avoided - in LocaleGuesser/BrowserLocaleGuesser.php, line 52 #153

Open
lunetics opened this issue May 9, 2015 · 0 comments

Comments

@lunetics
Copy link
Collaborator

lunetics commented May 9, 2015

in LocaleGuesser/BrowserLocaleGuesser.php, line 52

The or operator does not have the same precedence as ||.
This could lead to unexpected behavior, use || instead.

        $validator = $this->metaValidator;
        // Get the preferred locale from the Browser.
        $preferredLocale = $request->getPreferredLanguage();
        $availableLocales = $request->getLanguages();

        if (!$preferredLocale OR count($availableLocales) === 0) {
            return false;
        }

        // If the preferred primary locale is allowed, return the locale.
        if ($validator->isAllowed($preferredLocale)) {

Posted from SensioLabsInsight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant