Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Regeneration is Wonky on Rebuild #22

Closed
dwbuiten opened this issue Jul 1, 2019 · 3 comments
Closed

Header Regeneration is Wonky on Rebuild #22

dwbuiten opened this issue Jul 1, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@dwbuiten
Copy link
Collaborator

dwbuiten commented Jul 1, 2019

Right now, header generation generates some weird broken header (with wrong types, for example), or doesn't regnerate the header(s) at all, even though the C library is rebuilt.

Example:

  1. git clone https://github.com/xiph/rav1e/
  2. cd rav1e && cargo cinstall --prefix=whatever
  3. vim src/capi.rs and add a function or something
  4. cargo cinstall --prefix=/whatever
  5. Header is wrong.

If I run, e.g. git clean -fdx an then re-run cinstall, the header is generated correctly.

@lu-zero lu-zero added the bug Something isn't working label Jul 1, 2019
@lu-zero
Copy link
Owner

lu-zero commented Jul 1, 2019

It is a subset of #21. as workaround you can remove the buildinfo file for now.

@dwbuiten
Copy link
Collaborator Author

dwbuiten commented Jul 1, 2019

Ah, OK, I was not sure, but #21 reminded me when I saw it. Closing then.

@dwbuiten dwbuiten closed this as completed Jul 1, 2019
@lu-zero
Copy link
Owner

lu-zero commented Jul 1, 2019

We'd need to investigate why this happens though since in theory changing a file should trigger a rebuild in cargo and the rebuild should provide a different build info. If you could act as second brain here is where the bug could possibly be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants