Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP39 support for ED25519 #44

Open
jasny opened this issue May 2, 2022 · 1 comment
Open

BIP39 support for ED25519 #44

jasny opened this issue May 2, 2022 · 1 comment
Labels
wontfix This will not be worked on

Comments

@jasny
Copy link
Member

jasny commented May 2, 2022

Support BIP39 for generating private keys. For ED25519, BIP39 should an alternative to the current (brainwallet) seeding method.

Choosing BIP39 seeding should result in the same key pair for seed when using Ledger.

The current keyPairFromSeed method should move to a separate class BrainwalletEd25519. And a new class Bip39Ed25519 should be added.

To test if the implementation is correct

  • Generate a new wallet for LTO Network on Ledger
  • Get the 24-word seed
  • Use the seed to generate an Ed25519 keypair using Seasalt
  • Convert the public key to an address using the python or java library.
  • The address should be the same address as shown on the Ledger device.
@jasny jasny mentioned this issue May 2, 2022
@jasny
Copy link
Member Author

jasny commented Jul 19, 2023

This is not supported in clients of other languages (js, python). BIP32 / BIP39 is only supported for secp256k1. No need to support this unless it's changed in the LTO protocol and supported everywhere.

@jasny jasny added the wontfix This will not be worked on label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant