Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #26, modernize pkg config #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

codejedi365
Copy link

@codejedi365 codejedi365 commented Oct 30, 2021

This PR provides:

  1. Fix to a modern use of require(), which doesn't fail on node@>=10.24.
  2. I noticed from the flowconfig that it only defines index.js as the single file of code needed for the module. This same construct is available via files directive in package.json.
  3. The previous alternative to the files directive is the definition of .npmignore. I updated this to solve the issue in case files directive is not desired. The do not conflict with each other and files array takes precedence.

Resolves #26

@codejedi365
Copy link
Author

@loganfsmyth, any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old pkg config causes errors on transpile
1 participant