Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint CI test warns about pyparsing 3.1 #4580

Closed
joachimmetz opened this issue Mar 12, 2023 · 1 comment · Fixed by #4760
Closed

lint CI test warns about pyparsing 3.1 #4580

joachimmetz opened this issue Mar 12, 2023 · 1 comment · Fixed by #4760
Assignees
@joachimmetz
Milestone
2023 December rel...

Comments

@joachimmetz
Copy link
Member

Looks like pyparsing 3.1 alpha is upsetting pylint

pyparsing==3.1.0a1
...
lint: commands[2]> pylint --rcfile=.pylintrc plaso tests tools
************* Module plaso.parsers.text_plugins.vsftpd
plaso/parsers/text_plugins/vsftpd.py:52:23: E1121: Too many positional arguments for method call (too-many-function-args)
plaso/parsers/text_plugins/vsftpd.py:55:16: E1121: Too many positional arguments for method call (too-many-function-args)
plaso/parsers/text_plugins/vsftpd.py:58:17: E1121: Too many positional arguments for method call (too-many-function-args)
plaso/parsers/text_plugins/vsftpd.py:73:6: E1121: Too many positional arguments for method call (too-many-function-args)
@joachimmetz joachimmetz added this to the 2023 December release milestone Dec 14, 2023
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 16, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
7b6d6c5
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 17, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
76a243b
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 17, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
a5e7ed5
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
f9b1c22
@joachimmetz joachimmetz self-assigned this Dec 18, 2023
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
4f25abe
@joachimmetz
Copy link
Member Author

joachimmetz commented Dec 18, 2023 •
edited
Loading

Looks to be related to API function backwards compatibility https://github.com/pyparsing/pyparsing/blob/2a1a8e8f4beee7fd120c3fdc1a48725b77e263c2/pyparsing/core.py#L2268

joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
4e9183d
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
193dc45
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
9a301ad
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
843b115
@joachimmetz joachimmetz linked a pull request Dec 18, 2023 that will close this issue
Changes for pyparsing 3.1 #4580 #4760
Merged
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
5ad7ce6
joachimmetz added a commit to joachimmetz/plaso that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 log2timeline#4580
76e2355
joachimmetz added a commit that referenced this issue Dec 18, 2023
@joachimmetz
Changes for pyparsing 3.1 #4580 (#4760)
eb03cca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmetz joachimmetz

Labels
None yet
Projects
None yet
Milestone
2023 December release
Development

Successfully merging a pull request may close this issue.

Changes for pyparsing 3.1 #4580 joachimmetz/plaso
1 participant
@joachimmetz