Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DirectX] Implement Shader Flag Analysis for RequiresGroup #116276

Open
Tracked by #57
bharadwajy opened this issue Nov 14, 2024 · 0 comments
Open
Tracked by #57

[DirectX] Implement Shader Flag Analysis for RequiresGroup #116276

bharadwajy opened this issue Nov 14, 2024 · 0 comments

Comments

@bharadwajy
Copy link
Contributor

DXC sets the flag m_bRequiresGroup to indicate a function accesses group shared memory. It is set if any of the function instruction's type or operand type being a pointer into thread group shared memory - per this and this.

  1. Need to add SHADER_FEATURE_FLAG(32, 40, RequiresGroup, "Function accesses thread group shared memory") to llvm/include/llvm/BinaryFormat/DXContainerConstants.def.
  2. Set RequiresGroup if any of the function instruction's type or operand type being a pointer into thread group shared memory.

Clarification needed: Does clang use a separate address space or some other mechanism to represent thread group shared memory?

AC:

Add tests to verify correctness of analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planning
Development

No branches or pull requests

1 participant